Replaced mentions of web site to website#5639
Closed
LiamMcArthur wants to merge 1 commit intoWordPress:trunkfrom
Closed
Replaced mentions of web site to website#5639LiamMcArthur wants to merge 1 commit intoWordPress:trunkfrom
LiamMcArthur wants to merge 1 commit intoWordPress:trunkfrom
Conversation
ironprogrammer
suggested changes
Nov 9, 2023
Member
ironprogrammer
left a comment
There was a problem hiding this comment.
Mostly LGTM, @LiamMcArthur 👍🏻 One minor tweak suggested:
5ec962b to
c7afa1e
Compare
ironprogrammer
approved these changes
Nov 10, 2023
Member
ironprogrammer
left a comment
There was a problem hiding this comment.
LGTM 👍🏻 Thanks, @LiamMcArthur!
Member
|
Thanks for the PR! Merged in r57131. |
Author
|
@ironprogrammer @SergeyBiryukov I noticed these changes were reverted https://core.trac.wordpress.org/changeset/57113 - does anyone know what the reason for this was? |
Member
|
Hi, @LiamMcArthur -- Looking into this, on 2023-11-15 r57112 mistakenly included the updates from this PR alongside another patch, which were indeed reverted in r57113. However, the subsequent merge on 2023-11-22 of r57131 occurred later, and from what I see today in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated mentions of web site to website since the singular version does seem to be used more often throughout WordPress.
Trac ticket: https://core.trac.wordpress.org/ticket/59853#ticket
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.