Update npm packages to latest versions for 6.4 RC3 v2#5610
Closed
mikachan wants to merge 1 commit intoWordPress:trunkfrom
Closed
Update npm packages to latest versions for 6.4 RC3 v2#5610mikachan wants to merge 1 commit intoWordPress:trunkfrom
mikachan wants to merge 1 commit intoWordPress:trunkfrom
Conversation
Contributor
|
Pulling down the commit to test. |
Contributor
|
No console or PHP errors when applied locally. Next step: commit to |
hellofromtonya
approved these changes
Nov 1, 2023
Contributor
hellofromtonya
left a comment
There was a problem hiding this comment.
LGTM 👍 Marking for commit.
kebbet
reviewed
Nov 1, 2023
| * rendering when a plugin block has been found inside. It does so | ||
| * by adding an attribute called `data-wp-navigation-disabled` which | ||
| * is later handled by the front-end logic. | ||
| * |
Contributor
There was a problem hiding this comment.
The files in wp-includes/blocks are maintained by Gutenberg, not by Core. Very few of the functions in this directory include an @since annotation. It would good to open an issue in Gutenberg to discuss adding the annotation to all of the functions, filters, callbacks, etc. within this directory.
Contributor
|
Committed via https://core.trac.wordpress.org/changeset/57048. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/59411
Includes changes from WordPress/gutenberg#55736:
WordPress/gutenberg#55748 is not part of the package update and was already committed into Core.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.