New filter admin_canonical_url#5412
Closed
prionkor wants to merge 3 commits intoWordPress:trunkfrom
prionkor:trunk
Closed
New filter admin_canonical_url#5412prionkor wants to merge 3 commits intoWordPress:trunkfrom prionkor:trunk
prionkor wants to merge 3 commits intoWordPress:trunkfrom
prionkor:trunk
Conversation
audrasjb
requested changes
Oct 5, 2023
Contributor
audrasjb
left a comment
There was a problem hiding this comment.
Thanks for the patch! It looks good to me, I added some change requests ;)
Author
|
The failed test is timeout and not relevant to the change. What is the next step? |
Contributor
No worries, it clearly appears that it is a timeout, so this is not a blocker. |
audrasjb
approved these changes
Jan 10, 2024
Contributor
|
committed in https://core.trac.wordpress.org/changeset/57595 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket:
https://core.trac.wordpress.org/ticket/59545
Related PR #1504
Trac ticket:
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.