Avoid registering patterns on the frontend#5397
Closed
aristath wants to merge 3 commits intoWordPress:trunkfrom
Closed
Avoid registering patterns on the frontend#5397aristath wants to merge 3 commits intoWordPress:trunkfrom
aristath wants to merge 3 commits intoWordPress:trunkfrom
Conversation
spacedmonkey
reviewed
Oct 4, 2023
swissspidy
reviewed
Oct 4, 2023
Comment on lines
+331
to
+334
| // Avoid registering patterns on the frontend. | ||
| if ( ! is_admin() && ! wp_is_json_request() ) { | ||
| return; | ||
| } |
Member
There was a problem hiding this comment.
If we are doing checks like this, we are we even hooking this function on init? We could just call it conditionally where needed.
Member
Author
There was a problem hiding this comment.
Yeah, I was thinking about that as well... My concern is that many things in the editor are done in REST-API calls, and a hook like admin_init wouldn't be suitable in that case. Do you have any ideas on a hook that would work?
This patch here works when manually testing, I'm trying to figure out how to fix the PHPUnit failures now
Member
Author
|
Closing in favor of #5398 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/59532
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.