Revisions: slash meta values for previews#5344
Revisions: slash meta values for previews#5344adamsilverstein wants to merge 9 commits intoWordPress:trunkfrom
Conversation
Correct an issue where meta values with values like a quote `”` could not be previewed. update_metadata expects data to be slashed.
|
@adamsilverstein, If we remove the |
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Thanks @adamsilverstein for the PR. Approved with one question: #5344 (comment)
I added a test that failed before the patch, but removed it to get tests passing in 6927209 because it was causing other tests to fail (I suspect because it wasn't cleaning up completely). I'm going to try to reintroduce it in another spot. |
|
@mukeshpanchal27 - I reintroduced the test by putting it in the metaRevisions test file and cleaning it up a bit. This test fails before the PR and essentially reproduces the issue surfaced by the GB E2E test. |
|
Trying again in |
Correct an issue where meta values with values like a quote
”could not be previewed. update_metadata expects data to be slashed.To test this bug:
expected: footnote shows quote
actual: footnote is missing or missing quote
Trac ticket: https://core.trac.wordpress.org/ticket/20564
See also: WordPress/gutenberg#52988
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.