Templates: Introduce _remove_theme_attribute_from_template_part_block function#5316
Closed
ockham wants to merge 6 commits into
Closed
Templates: Introduce _remove_theme_attribute_from_template_part_block function#5316ockham wants to merge 6 commits into
ockham wants to merge 6 commits into
Conversation
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
508daf1 to
66afb4f
Compare
Contributor
Author
|
Committed to Core in https://core.trac.wordpress.org/changeset/56724. |
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a
_remove_theme_attribute_from_template_part_block()function that can be used as a callback argument fortraverse_and_serialize_block(s)on a parsed block tree in order to remove thethemeattribute from all Template Part blocks found therein, and deprecate_remove_theme_attribute_in_block_template_content().Counterpart to
_inject_theme_attribute_in_template_part_blockfrom #59338 (which superseded_inject_theme_attribute_in_block_template_content, deprecated in #59452).Trac ticket: https://core.trac.wordpress.org/ticket/59460
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.