Templates: Deprecate _inject_theme_attribute_in_block_template_content().#5307
Closed
ockham wants to merge 4 commits into
Closed
Templates: Deprecate _inject_theme_attribute_in_block_template_content().#5307ockham wants to merge 4 commits into
ockham wants to merge 4 commits into
Conversation
gziolo
approved these changes
Sep 26, 2023
gziolo
left a comment
Member
There was a problem hiding this comment.
It makes perfect sense 👍🏻
Thank you for working on it.
| * @return string Updated 'wp_template' content. | ||
| */ | ||
| function _inject_theme_attribute_in_block_template_content( $template_content ) { | ||
| _deprecated_function( __FUNCTION__, '6.4.0' ); |
Member
There was a problem hiding this comment.
I think you can also put the message with the new recommendation as 3rd argument in the call.
gziolo
approved these changes
Sep 26, 2023
Contributor
Author
|
Committed to Core in https://core.trac.wordpress.org/changeset/56719. |
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to deprecate
_inject_theme_attribute_in_block_template_content(), as it can be replaced by using_inject_theme_attribute_in_template_part_block()in combination withtraverse_and_serialize_blocks()on the parsed template blocks instead. Note that the function has always had@access privateset in its PHPDoc.The only code in Core that it's called from is synced from Gutenberg (dynamic blocks' PHP code).
get_block_file_templatefor rendering gutenberg#52892. This change will be synced to Core before Beta 1.Trac ticket: https://core.trac.wordpress.org/ticket/59452
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.