Remove deprecated 'print_emoji_styles' when generating the block editor's iframe assets#5305
Closed
Mamaduka wants to merge 1 commit intoWordPress:trunkfrom
Closed
Remove deprecated 'print_emoji_styles' when generating the block editor's iframe assets#5305Mamaduka wants to merge 1 commit intoWordPress:trunkfrom
Mamaduka wants to merge 1 commit intoWordPress:trunkfrom
Conversation
…or's iframe assets
spacedmonkey
approved these changes
Sep 26, 2023
Member
Author
|
Note: Fix here uses conditional check before removing and adding the callback. This differs from a fix that landed in the Gutenberg repo this morning. I'll sync changes back if this gets committed. |
Member
|
@hellofromtonya Do you want to review as well. I plan to commit once the unit tests pass. |
Contributor
|
Testing it now. Give me a few minutes. |
hellofromtonya
approved these changes
Sep 26, 2023
Contributor
hellofromtonya
left a comment
There was a problem hiding this comment.
Tested in a default local testing environment:
- Get the deprecation notice before applying this patch.
- After applying the patch, no more deprecation notice ✅
This change resolves the issue. LGTM for commit 👍
Contributor
|
@spacedmonkey LGTM for commit. Thank you everyone for resolving this issue! |
Member
|
Committed 6a06786 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR removes the recently deprecated
print_emoji_styleshandler when generating the block editor's iframe assets.Why
Deprecation notice triggered by the callback breaks editor styles when
WP_DEBUGis set to true.Testing Instructions.
wp.data.select( 'core/block-editor' ).getSettings().__unstableResolvedAssets.stylesScreenshot
Trac ticket: https://core.trac.wordpress.org/ticket/58775.