Image: Add the lightbox setting to theme.json#5248
Closed
michalczaplinski wants to merge 2 commits intoWordPress:trunkfrom
Closed
Image: Add the lightbox setting to theme.json#5248michalczaplinski wants to merge 2 commits intoWordPress:trunkfrom
michalczaplinski wants to merge 2 commits intoWordPress:trunkfrom
Conversation
This was referenced Sep 19, 2023
Contributor
tellthemachines
left a comment
There was a problem hiding this comment.
Thanks for the PR! The changes from lib/theme.json in the linked Gutenberg PR should also be added to the core theme.json file.
This can't really be tested in core without the scripts that will only be available after the packages are updated, but the changes don't break anything so should be safe to commit beforehand.
ee07015 to
348253a
Compare
Contributor
|
Added the theme.json change and rebased the branch to see if tests pass. |
Contributor
tellthemachines
left a comment
There was a problem hiding this comment.
I think we're good to go with this! ✅
Contributor
|
Committed in r56643. |
Contributor
Author
Thanks for following up on this @tellthemachines and sorry I didn't get to it yesterday! 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport PR for WordPress 6.4 that includes the following PHP Gutenberg changes:
Trac ticket: https://core.trac.wordpress.org/ticket/59393
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.