Improve optimisations of get_site_url#5054
Closed
soderlind wants to merge 3 commits intoWordPress:trunkfrom
Closed
Improve optimisations of get_site_url#5054soderlind wants to merge 3 commits intoWordPress:trunkfrom
soderlind wants to merge 3 commits intoWordPress:trunkfrom
Conversation
src/wp-includes/link-template.php
Outdated
| $url = $site->domain . $site->path; | ||
|
|
||
| // If the network has a custom domain, use that instead. | ||
| if ( \get_network()->domain !== $site->domain ) { |
Member
There was a problem hiding this comment.
Why \ use here? Code did not use it in any code references
Author
There was a problem hiding this comment.
Sorry, my bad. It's in my fingers, add them automatically because I always use namespace. I'll remove it i a few sec.
Author
|
Duplicate of https://core.trac.wordpress.org/ticket/64863, i.e 64863 fixes this and more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve optimisations of
get_site_url()by not usingswitch_to_blog, instead use theWP_Site_QueryqueryTrac ticket: https://core.trac.wordpress.org/ticket/59173