Preserve block style variations when securing theme#5013
Open
dsas wants to merge 2 commits intoWordPress:trunkfrom
Open
Preserve block style variations when securing theme#5013dsas wants to merge 2 commits intoWordPress:trunkfrom
dsas wants to merge 2 commits intoWordPress:trunkfrom
Conversation
Valid and safe block style variations were being removed by `WP_Theme_JSON::remove_insecure_properties` when securing the theme.json. When this was a problem varied depending upon site configuration, but out-of-the-box it was a problem for administrators on multi-site installs. This change adds explicit processing of variations in `remove_insecure_properties` so that they won't get removed.
ramonjd
reviewed
Aug 16, 2023
Author
|
@ramonjd, sorry I've been afk. What's the next step here? |
Member
|
Thanks for the ping! We're now looking for a core committer to give final review. Though I think it might now be punted to 6.3.2 (?) given that it's mentioned on: At any rate, I added it to the 6.3.x board a while back so it's on the radar. |
tellthemachines
approved these changes
Sep 1, 2023
Contributor
tellthemachines
left a comment
There was a problem hiding this comment.
Thanks for the PR, changes LGTM!
Contributor
|
Committed to trunk in r56502; leaving the PR open pending commit to the release branch. |
86 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Valid and safe block style variations were being removed by
WP_Theme_JSON::remove_insecure_propertieswhen securing the theme.json. When this was a problem varied depending upon site configuration, but out-of-the-box it was a problem for administrators on multi-site installs.This change adds explicit processing of variations in
remove_insecure_propertiesso that they won't get removed.Trac ticket: https://core.trac.wordpress.org/ticket/59108
This has already been merged as WordPress/gutenberg#53466 and is a manual sync of that change.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.