Fluid typography: add min and max viewport width configurable options#4989
Closed
ramonjd wants to merge 3 commits intoWordPress:trunkfrom
Closed
Fluid typography: add min and max viewport width configurable options#4989ramonjd wants to merge 3 commits intoWordPress:trunkfrom
ramonjd wants to merge 3 commits intoWordPress:trunkfrom
Conversation
This was referenced Aug 10, 2023
Merged
86 tasks
…pography.fluid theme.json schema, to allow theme developers to configure their own default min and max viewport widths for calculating fluid font sizes.
5913ae6 to
2c3ea4e
Compare
tellthemachines
approved these changes
Sep 7, 2023
Contributor
tellthemachines
left a comment
There was a problem hiding this comment.
Thanks for the PR, changes LGTM!
Contributor
|
Committed in r56535. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤞🏻 for WordPress 6.4
Backporting PHP changes from:
This PR adds configurable min and max viewport width values to the typography.fluid theme.json schema, to allow theme developers to configure their own default min and max viewport widths for calculating fluid font sizes.
The min and max viewport widths the boundaries, in terms of viewport widths, at which font size clamp values will stop being "fluid".
See WordPress/gutenberg#53081 for testing instructions.
Note that this PR will only affect the frontend.
A package update is required for the editor to reflect the changes.
Trac ticket: https://core.trac.wordpress.org/ticket/59048
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.