Update kses.php to allow HTML tags that contain colons like <esi:include>#4926
Closed
alewolf wants to merge 3 commits intoWordPress:trunkfrom
alewolf:trunk
Closed
Update kses.php to allow HTML tags that contain colons like <esi:include>#4926alewolf wants to merge 3 commits intoWordPress:trunkfrom alewolf:trunk
alewolf wants to merge 3 commits intoWordPress:trunkfrom
alewolf:trunk
Conversation
This allows HTML tag names that contain a colon such as <esi:include> (Those tags are specified by the ESI Languages Specification: https://www.w3.org/TR/esi-lang/)
Author
|
Here's the regex on regex101.com if you like to investigate it further: https://regex101.com/r/CdS2U2/1 Bear in mind that I had to add one backslash to make it work in regex101. The backslash is not necessary in the PHP code. |
costdev
reviewed
Jul 29, 2023
Author
|
I created a new PR for this that now includes a unit test: #4929 |
Author
|
@martinkrcho How do you mean? It is already closed... |
|
Scratch that. I didn't realite it's already closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows HTML tag names that contain a colon such as
<esi:include>The changed regex now allows zero or one colon within the tag name.
(
<esi:include>tags are specified by the ESI Languages Specification: https://www.w3.org/TR/esi-lang/)Trac ticket: https://core.trac.wordpress.org/ticket/58921
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.