Returns empty string if null value is passed for gmt_date#4776
Closed
adi3890 wants to merge 3 commits intoWordPress:trunkfrom
Closed
Returns empty string if null value is passed for gmt_date#4776adi3890 wants to merge 3 commits intoWordPress:trunkfrom
adi3890 wants to merge 3 commits intoWordPress:trunkfrom
Conversation
…-php8-warning-gmt_offset-value
Member
|
Thanks for the PR! Merged in r56132. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a check to verify data type
if $value
is_stringreturns $value, or else returns empty string.This prevents deprecation notice and also saves data as empty string as saved now.
Trac ticket: https://core.trac.wordpress.org/ticket/57728
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.