Navigation submenu block: deprecate deleted block_core_navigation_submenu_build_css_colors function#4762
Closed
ramonjd wants to merge 2 commits intoWordPress:trunkfrom
Conversation
…Press/gutenberg#48936 in favour of wp_apply_colors_support this commit adds a deprecation to core
ramonjd
commented
Jun 30, 2023
| /** | ||
| * Build an array with CSS classes and inline styles defining the colors | ||
| * which will be applied to the navigation markup in the front-end. | ||
| * |
Contributor
There was a problem hiding this comment.
@since 5.9.0, I remember adding it 😄
tellthemachines
approved these changes
Jul 3, 2023
Contributor
tellthemachines
left a comment
There was a problem hiding this comment.
LGTM! Added the @since in.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
block_core_navigation_submenu_build_css_colorswas deprecated in WordPress/gutenberg#48936 in favour ofwp_apply_colors_supportThis commit adds a deprecation to core.
See comment: https://github.com/WordPress/wordpress-develop/pull/4699/files#r1243172213
Props to @peterwilsoncc
Trac ticket: https://core.trac.wordpress.org/ticket/58623
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.