58304 Move filter intermediate_image_sizes_advanced position #4758
Open
nirav7707 wants to merge 1 commit intoWordPress:trunkfrom
Open
58304 Move filter intermediate_image_sizes_advanced position #4758nirav7707 wants to merge 1 commit intoWordPress:trunkfrom
intermediate_image_sizes_advanced position #4758nirav7707 wants to merge 1 commit intoWordPress:trunkfrom
Conversation
update the position of the filter intermediate_image_sizes_advanced from wp_create_image_subsizes function to _wp_make_subsizes function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket - https://core.trac.wordpress.org/ticket/58304
A pull request (PR) use to relocate the
intermediate_image_sizes_advancedfilter from thewp_create_image_subsizesfunction to the_wp_make_subsizesfunction. This change was made because thewp_update_image_subsizesfunction directly and indirectly invokes the_wp_make_subsizesfunction. When_wp_make_subsizesis called indirectly throughwp_create_image_subsizes, the filter is available. However, when_wp_make_subsizesis directly called, the filter is not available. By moving the filter to_wp_make_subsizes, it ensures consistent availability of the filter regardless of how_wp_make_subsizesis invoked.