Add kses support for repeat#4637
Closed
tellthemachines wants to merge 3 commits intoWordPress:trunkfrom
Closed
Conversation
Contributor
|
Support for |
azaozz
approved these changes
Jun 19, 2023
Contributor
Author
Definitely accidental! I wonder how it happened, I didn't edit those lines manually 🤔 Update: the changeset that added those lines was committed yesterday and my branch didn't have it yet. All the same, I wouldn't have expected that to happen. Anyway, it's now fixed! Thanks for noticing 😄 |
Contributor
peterwilsoncc
left a comment
There was a problem hiding this comment.
LGTM with one suggestion to cover my paranoia.
Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/58551
Adds support for the CSS
repeatfunction.The Trac ticket mentions support for
auto-fitand-fill, but in testing I realised those are already implicitly supported so no changes needed there.To test this change in the front end, apply the patch on top of #4625 and follow testing steps from that PR.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.