Skip to content

Conversation

@mamun94
Copy link

@mamun94 mamun94 commented May 17, 2023

Hi @kamplugins! 👋

Thank you for your contribution to WordPress! 💖

The grammatical mistake has been fixed.

Trac ticket: https://core.trac.wordpress.org/ticket/58334

Copy link
Contributor

@costdev costdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @mamun94! I've left a couple of additional corrections in this review.

*/
public function header() {
// Nothing, This will be displayed within a iframe.
// Nothing, This will be displayed within an iframe.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Nothing, This will be displayed within an iframe.
// Nothing. This will be displayed within an iframe.

*/
public function footer() {
// Nothing, This will be displayed within a iframe.
// Nothing, This will be displayed within an iframe.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Nothing, This will be displayed within an iframe.
// Nothing. This will be displayed within an iframe.

Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mamun94 Approved from my end, pending the changes from @costdev.

@afragen
Copy link
Member

afragen commented May 17, 2023

Also, approve with @costdev's changes.

@costdev
Copy link
Contributor

costdev commented May 17, 2023

Hi @mamun94! Are you available to update this pull request with the suggested changes above? 🙂

Changed the suggested issue updated.
@mamun94
Copy link
Author

mamun94 commented May 18, 2023

Hi,
@costdev Changed the suggested issue updated. 🙂🙂

Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me.

Copy link
Contributor

@costdev costdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @mamun94! LGTM! 👍

@SergeyBiryukov
Copy link
Member

Thanks for the PR! Merged in r55823.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants