Skip to content

Add aspect-ratio as a valid CSS property to kses#4032

Closed
ajlende wants to merge 2 commits intoWordPress:trunkfrom
ajlende:add/aspect-ratio-to-kses
Closed

Add aspect-ratio as a valid CSS property to kses#4032
ajlende wants to merge 2 commits intoWordPress:trunkfrom
ajlende:add/aspect-ratio-to-kses

Conversation

@ajlende
Copy link
Copy Markdown

@ajlende ajlende commented Feb 8, 2023

Adds aspect-ratio to safe_style_css list of properties. Required for WordPress/gutenberg#47854

Trac ticket: https://core.trac.wordpress.org/ticket/57664


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link
Copy Markdown
Contributor

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajlende Are you able to add aspect ration to the @since 6.2.0 annotation for the function

* @since 6.2.0 Added support for `position`, `top`, `right`, `bottom`, `left` and `z-index` position CSS properties.

@ajlende
Copy link
Copy Markdown
Author

ajlende commented Feb 8, 2023

Are you able to add aspect ration to the @since 6.2.0 annotation for the function

@peterwilsoncc Done!

Copy link
Copy Markdown
Contributor

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Copy Markdown
Contributor

@audrasjb audrasjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for 6.2 inclusion.

@audrasjb
Copy link
Copy Markdown
Contributor

committed in https://core.trac.wordpress.org/changeset/55309, with a couple modifications

@audrasjb audrasjb closed this Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants