Enhance performance of _add_block_template_part_area_info()#3975
Closed
felixarntz wants to merge 1 commit intoWordPress:trunkfrom
Closed
Enhance performance of _add_block_template_part_area_info()#3975felixarntz wants to merge 1 commit intoWordPress:trunkfrom
_add_block_template_part_area_info()#3975felixarntz wants to merge 1 commit intoWordPress:trunkfrom
Conversation
Member
Author
|
After giving this a performance benchmark, it shows there is a consistent improvement in performance of this function. However, the benefit is so small that making this logic change is probably not worth it.
Data based on medians for 20 requests. There is still a bottleneck here somewhere that we should probably find a way to address to make the overall time it takes to get the template parts faster. |
Member
Author
|
cc @spacedmonkey for visibility This optimization helps a tiny bit, but not really worth doing. Just wanted to let you know I gave this a try :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR optimizes performance of
_add_block_template_part_area_info()by only computing the most expensive logic once for all template parts, instead of doing it for every template part individually on request.Trac ticket:
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.