Remove get_default_block_editor_settings from theme JSON resolver#3902
Closed
Mamaduka wants to merge 6 commits intoWordPress:trunkfrom
Closed
Remove get_default_block_editor_settings from theme JSON resolver#3902Mamaduka wants to merge 6 commits intoWordPress:trunkfrom
Mamaduka wants to merge 6 commits intoWordPress:trunkfrom
Conversation
felixarntz
reviewed
Jan 24, 2023
Member
felixarntz
left a comment
There was a problem hiding this comment.
@Mamaduka Two small bits of feedback on the production code.
Can you add unit test coverage for the change please? Particularly a simple test for the new function. The get_default_block_editor_settings() change should already be covered by existing tests.
Member
Before
After
Performance improvement 👍 |
Member
Author
|
Updated the function name and added simple unit tests. |
felixarntz
reviewed
Jan 25, 2023
Member
felixarntz
left a comment
There was a problem hiding this comment.
@Mamaduka One last tiny bit of feedback, other than that this is good to go.
Member
Author
|
Good catch. Thank you, @felixarntz! |
Member
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Thanks @Mamaduka, I've left some feedback regarding the unit test in a PR review.
Member
Author
|
Thank you, @mukeshpanchal27! |
Member
|
Committed in https://core.trac.wordpress.org/changeset/55146 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/57547
Gutenberg PR: WordPress/gutenberg#46112
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.