Add isset() check to prevent logging warnings.#3880
Add isset() check to prevent logging warnings.#3880Sageth wants to merge 4 commits intoWordPress:trunkfrom
Conversation
In some cases, viewing a file will cause a PHP warning: ``` PHP Warning: Trying to access array offset on value of type null in /wp-includes/widgets.php on line 918" while reading response header from upstream, ..., request: "GET /attachment-sitemap4.xml HTTP/2.0", ..., referrer: "/sitemap_index.xml" ``` This appears to be a logging issue only.
|
Hi @Sageth! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
|
@Sageth are you still around and able to bring this up to date with |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Co-authored-by: John Parris <public@johnparris.com>
For resolving
FILE: src/wp-includes/widgets.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
928 | ERROR | [x] Array keys must be surrounded by spaces unless they contain
| | a string or an integer.
| | (WordPress.Arrays.ArrayKeySpacingRestrictions.NoSpacesAroundArrayKeys)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Updated with |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
In some cases, viewing a page or post will cause a PHP warning:
This appears to be a logging issue only.
Description of Change: Adding a check to see if the widget ID is set prior to evaluation.
Trac ticket: https://core.trac.wordpress.org/ticket/57518