Backport: Outline support for blocks in theme.json with unit test#3790
Closed
hellofromtonya wants to merge 3 commits intoWordPress:trunkfrom
Closed
Backport: Outline support for blocks in theme.json with unit test#3790hellofromtonya wants to merge 3 commits intoWordPress:trunkfrom
hellofromtonya wants to merge 3 commits intoWordPress:trunkfrom
Conversation
audrasjb
reviewed
Dec 19, 2022
Contributor
audrasjb
left a comment
There was a problem hiding this comment.
Perfect! Thanks for putting together this PR Tonya!
Just a small note: the margin-* and padding-* properties are listed in the same order they appear when listed on the padding and margin short notation: top, right, bottom, left.
For the sake of consistency, should we order the outline-* accordingly? width, style, color, then offset.
audrasjb
reviewed
Dec 19, 2022
Contributor
audrasjb
left a comment
There was a problem hiding this comment.
Hmm nevermind: this is not what we did for the border-* properties.
audrasjb
approved these changes
Dec 19, 2022
Contributor
Author
|
Thanks @audrasjb! Prepping commit right now. |
Contributor
Author
|
Committed in https://core.trac.wordpress.org/changeset/55008. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refresh of PR #3788: adds test commit (that fails before the backport) and then adds the backport commit, while ensuring it's based on
trunk.This PR backports the changes in #43526 that add support for the outline property on theme.json
Trac ticket: https://core.trac.wordpress.org/ticket/57354
Props: @MaggieCabrera and @audrasjb (from the previous PR)
How to Test
Open TT3's
theme.jsonand go to"elements"on about line 596 and then"button"on the next line. Then make the following changes:"border"):and in
":hover", add this code as the last entry (after"color"):Then add a new post and a button block. In the front-end it should render similar to this:
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.