Skip to content

Trac #45950 -- Update social media icons' size to 26#3668

Closed
dkeech wants to merge 1 commit intoWordPress:trunkfrom
dkeech:trunk
Closed

Trac #45950 -- Update social media icons' size to 26#3668
dkeech wants to merge 1 commit intoWordPress:trunkfrom
dkeech:trunk

Conversation

@dkeech
Copy link
Copy Markdown

@dkeech dkeech commented Nov 23, 2022

I updated the instances of svg icons in icon-functions.php to 26px from 24px.

Trac ticket: https://core.trac.wordpress.org/ticket/45950


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link
Copy Markdown

Hi @dkeech! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

@peterwilsoncc
Copy link
Copy Markdown
Contributor

@dkeech Can you drop a link to your WordPress profile in this this PR? I'm about to commit an iteration of this patch to WordPress and will add you to the props list once I hear back.

If you visit https://profiles.wordpress.org/me/profile/edit/group/1/ you can link your GitHub and WordPress profiles to make the process smoother in the future.

Thanks,
Peter

@peterwilsoncc
Copy link
Copy Markdown
Contributor

Iteration of this PR committed in r56447 / 40df0ec, Dan's props to be added manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants