56920 keyboard shortcuts comments link#3563
Closed
d-claassen wants to merge 3 commits into
Closed
Conversation
On /wp-admin/edit-comments.php the Help section has a link to the Documentation on Keyboard Shortcuts. The page it links to starts with information about the Editor Shortcuts. The 2nd part of the page is about Keyboard Shortcuts for Comments. This changes the link in the Help section to direct immediately to that 2nd part of the page.
…it page On /wp-admin/user-edit.php the Keyboard Shortcuts option has a link to the Documentation on Keyboard Shortcuts. The page it links to starts with information about the Editor Shortcuts. The 2nd part of the page is about Keyboard Shortcuts for Comments. This changes the link for the option to direct visitors immediately to that 2nd part of the page.
The text "Documentation on Keyboard Shortcuts" explains the link better than "More information" does. And the link in the user profile can open in the same tab. This actually gives users the possibility to decide for themselves if they prefer a new tab over the tab in use.
Contributor
|
Committed in https://core.trac.wordpress.org/changeset/55042 |
Author
|
Thanks, @audrasjb! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make links for "Keyboard Shortcuts" about comments go to the specific section on the support page. This also changes the link on user-edit.php by using the same phrasing and opening in the same window by default. That's done in a separate commit so it can be left out of this change.
Trac ticket: https://core.trac.wordpress.org/ticket/56920
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.