remove unnecessary condition from assets-loading#3395
Closed
aristath wants to merge 1 commit intoWordPress:trunkfrom
Closed
remove unnecessary condition from assets-loading#3395aristath wants to merge 1 commit intoWordPress:trunkfrom
aristath wants to merge 1 commit intoWordPress:trunkfrom
Conversation
Contributor
|
Nice job!! Work as expected |
Member
Author
|
Note: This was reported in WordPress/twentytwentythree#214, then WordPress/gutenberg#44638 |
Contributor
|
Merged into core in https://core.trac.wordpress.org/changeset/54367. |
mukeshpanchal27
approved these changes
Oct 3, 2022
Member
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Thanks @aristath. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears that an extra condition was preventing multiple scripts from loading in blocks like the navigation block - where we need a separate script for the modal.
This patch removes an additional condition that is not necessary.
Whether a style or script gets enqueued should not be related to the block's render callback.
Trac ticket: https://core.trac.wordpress.org/ticket/56408
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.