Skip to content

Backport appearance tools theme_support#3337

Closed
ockham wants to merge 1 commit intoWordPress:trunkfrom
ockham:backport/appearance-tools-theme-support
Closed

Backport appearance tools theme_support#3337
ockham wants to merge 1 commit intoWordPress:trunkfrom
ockham:backport/appearance-tools-theme-support

Conversation

@ockham
Copy link
Copy Markdown
Contributor

@ockham ockham commented Sep 27, 2022 •
edited by hellofromtonya
Loading

Backport of WordPress/gutenberg#43337.

Quoting that PR's description:

What?

Allow a theme to enable appearanceTools to any theme including classic themes.

Why?

Appearance tools are options in the block editor and don't require the use of the FSE to take advantage of. However there's no way to enable those tools for themes that don't use theme.json.

How?

This checks for the 'appearance-tools' support and if present flags settings.appearanceTools as true in the theme portion of Global Styles.

Testing Instructions

Using a theme that does NOT use a theme.json file enable the 'appearanceTools` theme support.

add_theme_support( 'appearance-tools' );

Add a group block to a new post. Note the block settings panel includes Border settings.

Trac ticket: https://core.trac.wordpress.org/ticket/56467
Trac ticket: https://core.trac.wordpress.org/ticket/56487

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@ockham ockham self-assigned this Sep 27, 2022
@ockham ockham mentioned this pull request Sep 27, 2022
Merged
@hellofromtonya
Copy link
Copy Markdown
Contributor

hellofromtonya commented Sep 27, 2022

Hmm, this is marked as a Feature in the original Gutenberg PR and an enhancement in the Trac ticket (which is not in the 6.1 milestone). Sadly, this one missed the 6.1 feature freeze deadline.

Could it be reclassified? Deferring that decision to 6.1 Core Tech Leads @jeffpaul @dream-encode @getsource.

@dream-encode
Copy link
Copy Markdown
Contributor

dream-encode commented Sep 27, 2022

From Trac:
@hellofromTonya Thanks for the ping. In reading the discussion above it seems that testing is needed for each theme before adding the support. I really respect @poena's opinion as she's much more plugged in to FSE development.
Moving this to 6.2.

@ockham
Copy link
Copy Markdown
Contributor Author

ockham commented Sep 28, 2022

Thank you @dream-encode! I'll move the PR to "Bumped to 6.2" on our project board 👍

@ockham ockham force-pushed the backport/appearance-tools-theme-support branch from 8eca7ef to 331e060 Compare January 2, 2023 10:39
@ockham
Copy link
Copy Markdown
Contributor Author

ockham commented Jan 2, 2023

@hellofromtonya @azaozz @ironprogrammer Here's another PR that didn't make the cut for WP 6.1 -- for y'all's consideration for (early) inclusion in 6.2 😊

@carolinan
Copy link
Copy Markdown
Contributor

carolinan commented Jan 13, 2023

The earlier, the more time there is to test using the theme support in the bundled themes.

@ironprogrammer ironprogrammer mentioned this pull request Jan 13, 2023
Closed
@ironprogrammer
Copy link
Copy Markdown
Member

ironprogrammer commented Jan 13, 2023

@ockham In #3846 I've added a unit test for this support, and opened an early backport ticket in Trac 57460. ("Early" as in before 6.2 crunch time 😅)

@ockham
Copy link
Copy Markdown
Contributor Author

ockham commented Jan 17, 2023

Perfect, thank you very much @ironprogrammer! Closing this in favor of #3846 (which I see has already been merged 🎉)

@ockham ockham closed this Jan 17, 2023
@ockham ockham deleted the backport/appearance-tools-theme-support branch January 17, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ockham ockham

Labels

None yet

Projects

No open projects
WordPress 6.1 Editor Tasks
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ockham @hellofromtonya @dream-encode @carolinan @ironprogrammer