Closed
Conversation
Member
|
This is already looking good. Added some early feedback. The unit test failure, you may want to look into that. |
Closed
felixarntz
reviewed
Jul 12, 2022
Member
felixarntz
left a comment
There was a problem hiding this comment.
@tillkruss Idea-wise this looks good to me, however I think the API is overly complicated mostly due to its uncommon array support. I think we should remove that.
felixarntz
approved these changes
Jul 20, 2022
Member
felixarntz
left a comment
There was a problem hiding this comment.
@tillkruss Looks great now, thanks for the updates!
Member
|
Marking a ready to commit. |
peterwilsoncc
approved these changes
Jul 21, 2022
Contributor
peterwilsoncc
left a comment
There was a problem hiding this comment.
As with the others this LGTM.
I've added an inline suggestion for a minor formatting change of the docblock. Mainly to keep the formatting nice on the developer docs.
Member
|
Committed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacement for #2368.
Resolves WordPress/performance#38.
Trac ticket: https://core.trac.wordpress.org/ticket/4476
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.