Closed
Conversation
Contributor
Author
|
Fixed typos in this last section:
|
SergeyBiryukov
approved these changes
May 3, 2022
Member
|
The PR looks great to me 👍 |
Contributor
Author
|
Committed in r53339. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the header styles to all About-section pages, and add the content from the About page doc. Some responsive styles have been added — the page titles use a scaling font size so it fits in the header space without overlapping the image — but if there are other issues we can iterate during RC.
Screenshot of the full about page:
The content changed a little from when it was put into the design, but it mostly all still fit. The biggest change from the design is the "More Template Choices" section, which I switched to a single narrow column so that the "with the following new options […]" text would clearly flow into the next section.
This is what it would look like with the original design:
Other About section pages have the headers updated:
Credits page:
Freedoms page:
Privacy page:
Trac ticket: https://core.trac.wordpress.org/ticket/55434
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.