Skip to content

Conversation

@DSGND
Copy link

@DSGND DSGND commented Apr 29, 2022

Check if function get_comment_id is null before executing it.

Trac ticket: https://core.trac.wordpress.org/ticket/52322

@github-actions
Copy link

Hi @DSGND! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

Copy link
Contributor

@audrasjb audrasjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Two feedback added.

@DSGND DSGND requested a review from audrasjb December 14, 2022 00:25
audrasjb and others added 2 commits February 6, 2023 09:30
Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>
@audrasjb
Copy link
Contributor

audrasjb commented Feb 6, 2023

I added one commit to the PR to fix a WPCS issue

Copy link
Contributor

@audrasjb audrasjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@audrasjb
Copy link
Contributor

audrasjb commented Feb 7, 2023

@audrasjb audrasjb closed this Feb 7, 2023
@DSGND DSGND deleted the issue-52322/comment-id branch September 26, 2024 10:31
@DSGND DSGND restored the issue-52322/comment-id branch September 26, 2024 10:31
@DSGND DSGND deleted the issue-52322/comment-id branch September 26, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants