https://core.trac.wordpress.org/ticket/55121#2294
https://core.trac.wordpress.org/ticket/55121#2294jondcampbell wants to merge 2 commits intoWordPress:trunkfrom
Conversation
My attempt at a way to allow widgets that don't have any settings to show up. The change in 5.9 to isset within the display_callback made it so my settings array that has a value of null for the instance number hides my widget. I would like it if we allowed for objects and used isset for that but if the $instances is an array we can continue using array_key_exists so that widgets with no settings can work. I recently added a ticket about the issue at https://core.trac.wordpress.org/ticket/55121 and hoping this solves that.
|
Hi @jondcampbell! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>
There was a problem hiding this comment.
- Minimal changes to implement a fix.
- Unit Tests pass.
- PHP 5.6 - 8.1 show the expected outcomes.
LGTM, let's see what others say upon review of the ticket and the PR.
My attempt at a way to allow widgets that don't have any settings to show up.
The change in 5.9 to isset within the display_callback made it so my settings array that has a value of null for the instance number hides my widget. I would like it if we allowed for objects and used isset for that but if the $instances is an array we can continue using array_key_exists so that widgets with no settings can work.
I recently added a ticket about the issue at https://core.trac.wordpress.org/ticket/55121 and hoping this solves that.
Trac ticket:
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.