Skip to content

Templates Controller: Fix slug pattern to allow 404 templates#2077

Closed
ockham wants to merge 3 commits intoWordPress:trunkfrom
ockham:fix/template-controller-slug-pattern
Closed

Templates Controller: Fix slug pattern to allow 404 templates#2077
ockham wants to merge 3 commits intoWordPress:trunkfrom
ockham:fix/template-controller-slug-pattern

Conversation

@ockham
Copy link
Copy Markdown
Contributor

@ockham ockham commented Dec 22, 2021

Backport of WordPress/gutenberg#37579. Props @PatelUtkarsh.

Quoting WordPress/gutenberg#37579:

Description

Adding 404 template from /wp-admin/site-editor.php?postType=wp_template causes 400 with rest_invalid_pattern

How has this been tested?

  • Theme without 404 templates.
  • Open /wp-admin/site-editor.php?postType=wp_template
  • Add new 404 templates.
  • Used nightly WordPress build to test this.

Screenshots

Bug:

adding-404-template.mp4

Trac ticket: https://core.trac.wordpress.org/ticket/54680

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@ockham ockham mentioned this pull request Dec 22, 2021
Merged
7 tasks
@ockham
Copy link
Copy Markdown
Contributor Author

ockham commented Dec 23, 2021

cc/ @hellofromtonya @noisysocks @youknowriad -- I think this should go into 5.9 :)

@SergeyBiryukov
Copy link
Copy Markdown
Member

SergeyBiryukov commented Dec 26, 2021

Thanks for the PR! This looks good to me. It would also be great to include a unit test for this, some other tests in the phpunit/tests/rest-api/wpRestTemplatesController.php file could be used as a reference.

@ockham
Copy link
Copy Markdown
Contributor Author

ockham commented Jan 3, 2022

Thanks for the PR! This looks good to me. It would also be great to include a unit test for this, some other tests in the phpunit/tests/rest-api/wpRestTemplatesController.php file could be used as a reference.

Sure, happy to add a test!

hellofromtonya
hellofromtonya approved these changes Jan 3, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@hellofromtonya hellofromtonya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the integration test @ockham! LGTM 👍 Ready for commit.

@ockham
Copy link
Copy Markdown
Contributor Author

ockham commented Jan 4, 2022

Thanks a lot for reviewing @SergeyBiryukov @rachelbaker @hellofromtonya!

Since I don't have Core commit privileges myself, can I ask one of you kind souls to commit this? 😄

@audrasjb
Copy link
Copy Markdown
Contributor

audrasjb commented Jan 4, 2022

Committed in https://core.trac.wordpress.org/changeset/52436

@audrasjb audrasjb closed this Jan 4, 2022
@ockham ockham deleted the fix/template-controller-slug-pattern branch January 4, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SergeyBiryukov SergeyBiryukov SergeyBiryukov approved these changes

@rachelbaker rachelbaker rachelbaker approved these changes

@hellofromtonya hellofromtonya hellofromtonya approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ockham @SergeyBiryukov @audrasjb @rachelbaker @hellofromtonya