Add visibility switch to Settings > Writing password field.#2070
Open
costdev wants to merge 9 commits intoWordPress:trunkfrom
Open
Add visibility switch to Settings > Writing password field.#2070costdev wants to merge 9 commits intoWordPress:trunkfrom
Settings > Writing password field.#2070costdev wants to merge 9 commits intoWordPress:trunkfrom
Conversation
Contributor
peterwilsoncc
left a comment
There was a problem hiding this comment.
On the options page, I am seeing a JavaScript error in the console Uncaught TypeError: can't access property "data", $toggleButton is undefined and the toggle button is not working.
The user-profile javascript also includes code for setting the colour scheme on a users profile. These settings aren't available on the settings page so it seems a little hacking to include the JavaScript.
It's yet another JavaScript file but given how much the password toggle is used in core, it may be worth moving it in to a separate file.
65e0b0b to
6307643
Compare
added 7 commits
October 16, 2022 04:00
Previously, the password input on Options > Writing was focused on load. The `#mailserver_pass` input field is now excluded from this behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/9883