Copy capabilities from menu items to wp_navigation#2056
Closed
spacedmonkey wants to merge 2 commits intoWordPress:trunkfrom
Closed
Copy capabilities from menu items to wp_navigation#2056spacedmonkey wants to merge 2 commits intoWordPress:trunkfrom
spacedmonkey wants to merge 2 commits intoWordPress:trunkfrom
Conversation
7 tasks
hellofromtonya
approved these changes
Dec 17, 2021
Contributor
|
@spacedmonkey @hellofromtonya I think we should adjust this change set to match https://github.com/WordPress/gutenberg/pull/37454/files#diff-68aa3e914d52bce59d8cfcac6c7a10cad3bb8dca6021d00be35bdf546a6ea161R53. 'capabilities' => array(
'edit_others_posts' => 'edit_theme_options',
'delete_posts' => 'edit_theme_options',
'publish_posts' => 'edit_theme_options',
'create_posts' => 'edit_theme_options',
'read_private_posts' => 'edit_theme_options',
'delete_private_posts' => 'edit_theme_options',
'delete_published_posts' => 'edit_theme_options',
'delete_others_posts' => 'edit_theme_options',
'edit_private_posts' => 'edit_theme_options',
'edit_published_posts' => 'edit_theme_options',
),If we don't then as things stand in Gutenberg folks with lower permissions won't be able to "read" Navigation posts. That's why we adjusted the permissions as per WordPress/gutenberg#37454 (comment). |
audrasjb
approved these changes
Dec 24, 2021
Contributor
audrasjb
left a comment
There was a problem hiding this comment.
The proposed patch looks good to me 👍
Contributor
|
@hellofromtonya can we close this one out now? |
Contributor
|
Thanks for the ping @getdave. Yes, this can be closed. Committed via https://core.trac.wordpress.org/changeset/52400. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/54487
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.