Filter custom block templates with PHP#2031
Closed
Mamaduka wants to merge 1 commit intoWordPress:trunkfrom
Closed
Conversation
youknowriad
reviewed
Dec 8, 2021
| foreach ( get_post_types( array( 'public' => true ) ) as $type ) { | ||
| $block_templates = get_block_templates( array( 'post_type' => $type ), 'wp_template' ); | ||
| foreach ( $block_templates as $block_template ) { | ||
| if ( ! $block_template->is_custom ) { |
Contributor
There was a problem hiding this comment.
I feel maybe this should be internal to get_block_templates (an argument of the query) but I'm fine with this approach as well.
youknowriad
approved these changes
Dec 8, 2021
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for #2020.
This method calls
get_block_templatesonce and uses block template properties directly for filtering. This way, we can avoid hitting the database for each public post type.The previous method is useful when we already know the current post type we request templates for, like when using REST API.
Trac ticket: https://core.trac.wordpress.org/ticket/54335
Cc @youknowriad @noisysocks @hellofromtonya