Add: Global Styles Rest endpoints#1816
Closed
jorgefilipecosta wants to merge 1 commit intoWordPress:trunkfrom
Closed
Add: Global Styles Rest endpoints#1816jorgefilipecosta wants to merge 1 commit intoWordPress:trunkfrom
jorgefilipecosta wants to merge 1 commit intoWordPress:trunkfrom
Conversation
0140996 to
479afc0
Compare
oandregal
approved these changes
Nov 8, 2021
Member
oandregal
left a comment
There was a problem hiding this comment.
This worked as advertised.
For testing the theme I've used the TwentyTwentyOne theme with the theme.json described in this other PR #1808 I couldn't get tt1-blocks to work without the Gutenberg plugin active.
(await wp.apiFetch({path: 'wp/v2/global-styles/themes/twentytwentyone' } ) );
As for the code, I've noticed we're missing @since 5.9 tags. It also needs rebasing from #1808
479afc0 to
6e541f9
Compare
6e541f9 to
0baea5b
Compare
Member
Author
|
Thank you for the review @oandregal it was committed in 5ca3347. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing
With the tt1 block's theme active.
I opened the post editor, and then opened the browser console and execute the following commands:
User endpoint
Theme endpoint