Gallery: update the get_post_galleries method to account for gallery blocks#1783
Closed
glendaviesnz wants to merge 1 commit intoWordPress:masterfrom
Closed
Gallery: update the get_post_galleries method to account for gallery blocks#1783glendaviesnz wants to merge 1 commit intoWordPress:masterfrom
glendaviesnz wants to merge 1 commit intoWordPress:masterfrom
Conversation
Author
|
Once there is agreement on the way forward with this I will add some additional unit tests |
Author
|
Closed in favour of #1788 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently the get_post_galleries method will only handle gallery shortcodes. A trac ticket has been open for some time to rectify this, and in the meantime a new version of the gallery block is about to be released which uses innerblocks, so the diffs on this ticket will no longer be sufficient.
This PR adds support for both versions of the gallery block
To test:
Trac ticket: https://core.trac.wordpress.org/ticket/43826