Fix for theme.json: color.duotone and spacing.units should allow empty sets#1489
Closed
oandregal wants to merge 2 commits intoWordPress:masterfrom
oandregal:fix/empty-sets-for-duotone-and-units
Closed
Fix for theme.json: color.duotone and spacing.units should allow empty sets#1489oandregal wants to merge 2 commits intoWordPress:masterfrom oandregal:fix/empty-sets-for-duotone-and-units
theme.json: color.duotone and spacing.units should allow empty sets#1489oandregal wants to merge 2 commits intoWordPress:masterfrom
oandregal:fix/empty-sets-for-duotone-and-units
Conversation
Member
Author
|
cc @desrosj @youknowriad @jorgefilipecosta in case you can help land this and port it to the WordPress 5.8 branch. |
jorgefilipecosta
approved these changes
Jul 8, 2021
Member
jorgefilipecosta
left a comment
There was a problem hiding this comment.
The change looks good to me 👍 I'm going to commit it.
Member
|
Committed on 6bd5962 this PR can be closed :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of https://core.trac.wordpress.org/ticket/53175
This ports this PR WordPress/gutenberg#33280 The JS changes in that PR will be ported in the next package release and both are independent (they fix two related but separate things).
How to test
theme.jsonin the TwentyTwentyOne theme (or add the same contents to any theme withtheme.jsonsupport):pxunits. Before this change, it'll show all units.