Skip to content

Fix a notice caused by the viewScript containing .min for the core/file block.#1450

Closed
desrosj wants to merge 1 commit intoWordPress:masterfrom
desrosj:trac/53397-notice-fix
Closed

Fix a notice caused by the viewScript containing .min for the core/file block.#1450
desrosj wants to merge 1 commit intoWordPress:masterfrom
desrosj:trac/53397-notice-fix

Conversation

@desrosj
Copy link
Copy Markdown
Member

@desrosj desrosj commented Jun 30, 2021

Trac ticket: https://core.trac.wordpress.org/ticket/53397


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@desrosj
Copy link
Copy Markdown
Member Author

desrosj commented Jul 7, 2021

Merged into Core in https://core.trac.wordpress.org/changeset/51267 but later reverted in https://core.trac.wordpress.org/changeset/51288 as there were still issues with the implementation.

@desrosj desrosj closed this Jul 7, 2021
@desrosj desrosj deleted the trac/53397-notice-fix branch July 7, 2021 16:29
@desrosj desrosj restored the trac/53397-notice-fix branch September 14, 2022 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant