Update packages with fixes for WP 5.8 beta 4#1430
Closed
youknowriad wants to merge 5 commits intoWordPress:masterfrom
Closed
Update packages with fixes for WP 5.8 beta 4#1430youknowriad wants to merge 5 commits intoWordPress:masterfrom
youknowriad wants to merge 5 commits intoWordPress:masterfrom
Conversation
Member
I have a patch ready in the Gutenberg plugin WordPress/gutenberg#32977 that will require publishing to npm. Once it is available to npm, we can clean up #1412 and merge it with this branch. Maybe it's better to land this branch first and tackle #1412 separately? |
desrosj
approved these changes
Jun 25, 2021
Member
desrosj
left a comment
There was a problem hiding this comment.
The changes themselves look good to me. Haven't tested, but I'm sure these were tested enough in the plugin. 👍🏼
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes the fixes in this PR WordPress/gutenberg#32956 and WordPress/gutenberg#32992
Trac ticket https://core.trac.wordpress.org/ticket/53397