Update packages with fixes for WP 5.8 beta 4#1429
Closed
youknowriad wants to merge 2 commits intomasterfrom
Closed
Update packages with fixes for WP 5.8 beta 4#1429youknowriad wants to merge 2 commits intomasterfrom
youknowriad wants to merge 2 commits intomasterfrom
Conversation
Contributor
|
I'm not totally sure if there's a process for it, but if other non-JS changes are happening here, I think the pattern change can be included. |
Contributor
Author
|
Looks like I messed up, I'll recreate the PR on my fork. @ryelle I think there's no real defined process. In general, for php changes, if these are independent of the JS ones (packages updates), it's fine to do a separate commit but I know that sometimes we just do everything at once for simplicity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes the fixes in this PR WordPress/gutenberg#32956
Trac ticket https://core.trac.wordpress.org/ticket/53397