Skip to content

Build Tools: Copy block-library PHP metadata files with PHP source files#131

Closed
chipsnyder wants to merge 1 commit intoWordPress:masterfrom
chipsnyder:rnmobile/shortcode-support
Closed

Build Tools: Copy block-library PHP metadata files with PHP source files#131
chipsnyder wants to merge 1 commit intoWordPress:masterfrom
chipsnyder:rnmobile/shortcode-support

Conversation

@chipsnyder
Copy link
Copy Markdown

Fixes: https://core.trac.wordpress.org/ticket/49196
Related to: WordPress/gutenberg#19534

Looks to see if there is a block.json file in the same directory as the block's defined in phpfiles then copies those to the same directory.

@gziolo
Copy link
Copy Markdown
Member

gziolo commented Jan 15, 2020

Thank you for opening this PR. It should be filed in WordPress trac:
https://core.trac.wordpress.org

This is only a mirror of svn repository and it's useful for testing against Continues Integration.

Edit:
Forget about my comment, I didn't read the description careful enough :)

@chipsnyder
Copy link
Copy Markdown
Author

Thanks for taking the time to look at it @gziolo. I updated the PR based on the suggestions and updated the diff in the ticket as well. I had failed to read the contributing guide close enough which is why I opened this PR first then added it to the ticket. I can close it after you get a chance to look at the changes :)

@gziolo
Copy link
Copy Markdown
Member

gziolo commented Jan 21, 2020

Can you have a look at https://core.trac.wordpress.org/attachment/ticket/49196/49196-block-folders.diff which I prepared to make it work without errors when running npm run build:dev in WordPress core?

If you are fine with the changes proposed, it would be great to validate them on Travis in this branch.

@chipsnyder chipsnyder closed this Jan 30, 2020
@chipsnyder
Copy link
Copy Markdown
Author

Reopening with new changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants