Only load wp-editor-classic-layout-styles styles for themes without theme.json support#1290
Closed
oandregal wants to merge 5 commits into
Closed
Only load wp-editor-classic-layout-styles styles for themes without theme.json support#1290oandregal wants to merge 5 commits into
oandregal wants to merge 5 commits into
Conversation
Closed
28 tasks
youknowriad
reviewed
May 24, 2021
Contributor
|
This is looking good. |
Contributor
|
committed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of https://core.trac.wordpress.org/ticket/53175
See WordPress/gutenberg#31322
Related WordPress/gutenberg#30375
How to test
Activate a theme without
theme.jsonsupport (TwentyTwenty):wp-editor-classic-layout-styles-cssexternal stylesheet is loaded.Activate a theme with
theme.jsonsupport (TT1-blocks from the github repo not from the WordPress theme's repo, or add a theme.json file to the TwentyTwentyOne theme):wp-editor-classic-layout-styles-cssexternal stylesheet is not loaded.