Editor: Update WordPress packages published for Gutenberg 10.6 by gziolo · Pull Request #1257 · WordPress/wordpress-develop

gziolo · 2021-05-14T12:33:07Z

Trac ticket: https://core.trac.wordpress.org/ticket/52991

TODO

It needs more work:

All newly exposed core blocks aren't registered on the server. It requires changes in webpack build and some references for PHP files for most of the blocks.
Duotone supports need to be backported (Add duotone block supports gutenberg#26752).
Other PHP changes between 10.5 and 10.6 need to be validated.
~~Changes to lib/block-patterns/three-columns-media-text.php pattern~~ – it looks up to date
Changes to layout and border block supports
~~Some php changes to support the iframed template editor cc @ellatrix~~ – it's tracked separately and it depends on other changes

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

gziolo · 2021-05-14T12:33:52Z

Gruntfile.js

 						WORKING_DIR + 'wp-content/themes/twenty*/**/*.js',
 						'!' + WORKING_DIR + 'wp-content/themes/twenty*/node_modules/**/*.js',
-						'!' + WORKING_DIR + 'wp-includes/js/dist/vendor/*.js',
+						'!' + WORKING_DIR + 'wp-includes/js/dist/**/*.js',


We no longer publish ES5 code to npm. All WordPress packages work with ES2015+ from now on.

Can you clarify the change a bit more :p

This excludes WP packages from JSHint validation. js/dist folder contains files built from node_modules with webpack.

youknowriad · 2021-05-17T08:19:29Z

I updated the todo list with a few required items as well.

gziolo · 2021-05-17T16:50:36Z

Site Logo block registers 3 filters in addition to block registration:
https://github.com/WordPress/gutenberg/blob/bed089677e91b4ae00916645139c7f806f46ce8b/packages/block-library/src/site-logo/index.php#L74-L75
https://github.com/WordPress/gutenberg/blob/bed089677e91b4ae00916645139c7f806f46ce8b/packages/block-library/src/site-logo/index.php#L126

Do you think we should apply those changes directly to WP core?

Those changes fail 2 unit tests:

1) Tests_General_Template::test_has_custom_logo
Failed asserting that true is false.

/var/www/tests/phpunit/tests/general/template.php:265

2) Tests_General_Template::test_get_custom_logo
Failed asserting that a string is empty.

/var/www/tests/phpunit/tests/general/template.php:310

I think those filters will get executed twice once we land the block in WP core.

gziolo · 2021-05-17T18:02:31Z

src/wp-includes/block-supports/duotone.php

@@ -0,0 +1,392 @@
+<?php
+/**
+ * Duotone block support flag.


As discussed in WordPress/gutenberg#26752 (comment) with @ajlende, we need to include the license detailed for the code derived from the TinyColor library.

gziolo · 2021-05-18T06:30:15Z

I scanned quickly changes applied between 10.5 and 10.6 and I might have covered all of them with the last commit. We need to double-check: WordPress/gutenberg@release/10.5...release/10.6.

I backported all changes for block supports in 934ec7a. I left there 2 TODO items where I had to removed logic that depends on Global Styles in the layout support. It's something we need to explicitly list for the next round so it's wired correctly.

gziolo · 2021-05-18T06:32:19Z

src/wp-includes/block-supports/layout.php

+
+	$used_layout = $block['attrs']['layout'];
+	if ( isset( $used_layout['inherit'] ) && $used_layout['inherit'] ) {
+		// TODO: Add theme.json handling for the default layout.


@youknowriad, it might be that you didn't backport this part earlier because it makes sense only when Global Styles are in place.

Yes, I left the whole "layout" support for later (when theme.json lands) because it should be disabled for themes without that.

Right, so we probably can remove it here as well. It's most likely dead code anyway.

gziolo · 2021-05-18T06:38:37Z

I found the logic that is related to:

Some php changes to support the iframed template editor

https://github.com/WordPress/gutenberg/blob/b5f6955742e784f11828e1dacba4361713135963/lib/client-assets.php#L707-L744

It looks like something that could be done separately.

youknowriad · 2021-05-18T08:18:01Z

src/wp-includes/block-supports/border.php

+		( true === _wp_array_get( $block_type->supports, array( '__experimentalBorder' ), $default ) )
+	) {
+		return true;
+	}


This part can probably use block_has_support as well without the nested $feature thing but I guess that comment is better in the Gutenberg repo :)

Yes, let's fix in Gutenberg and backport with 10.7 version.

youknowriad · 2021-05-18T08:20:47Z

@gziolo did we include the 10.6.1 package update and php changes here?

gziolo · 2021-05-18T08:31:56Z

did we include the 10.6.1 package update and php changes here?

If 10.6.1 was published this week, then the answer is no.

youknowriad · 2021-05-18T08:56:50Z

I noticed that the editor styles are not applied properly (compared to the plugin), not sure why. You can compare with tt1 theme, you'll see that the background is not applied

youknowriad · 2021-05-18T09:02:21Z

Nevermind, I was testing with tt1-blocks and theme.json based styles are not backported yet, so we're all good here.

ellatrix · 2021-05-18T09:03:57Z

Looking at the iframe stuff. Trying to get this branch running first.

gziolo · 2021-05-18T14:19:17Z

I removed the Site Logo block for now because it creates too much friction, and I couldn't find a simple way to make failing tests pass without changing assertions. It needs to be investigated separately.

Technically speaking, this block will be still exposed in the inserter, but it won't work correctly until we include PHP bits.

gziolo · 2021-05-19T16:28:56Z

Closed with https://core.trac.wordpress.org/changeset/50929.

gziolo self-assigned this May 14, 2021

gziolo commented May 14, 2021

View reviewed changes

gziolo requested a review from youknowriad May 14, 2021 13:17

gziolo added the dependencies Pull requests that update a dependency file label May 14, 2021

gziolo mentioned this pull request May 17, 2021

Add duotone block supports WordPress/gutenberg#26752

Merged

6 tasks

gziolo commented May 17, 2021

View reviewed changes

gziolo commented May 18, 2021

View reviewed changes

youknowriad reviewed May 18, 2021

View reviewed changes

gziolo marked this pull request as ready for review May 18, 2021 14:18

gziolo added 7 commits May 19, 2021 08:35

Editor: Update WordPress packages published for Gutenberg 10.6

7dadab1

Expose stabilized theme blocks

46d2374

Add duotone support for blocks

fd24471

Apply changes introduced to block supports

904148e

Removed dead code for layout supports

86bc8fa

Add license information for code derived from TinyColor

bac3140

Remove Site Logo block

9921bdb

gziolo mentioned this pull request May 19, 2021

Hide the PostAuthor block behind the Gutenberg experimental flag WordPress/gutenberg#31983

Merged

gziolo closed this May 19, 2021

gziolo deleted the update/gutenberg-plugin-10.6 branch May 19, 2021 16:29

gziolo mentioned this pull request May 19, 2021

Merge the Gutenberg Updates into WordPress Trunk for the 5.8 release WordPress/gutenberg#31322

Closed

28 tasks

Conversation

gziolo commented May 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODO

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

youknowriad commented May 17, 2021

Uh oh!

gziolo commented May 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gziolo May 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gziolo commented May 18, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gziolo commented May 18, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

youknowriad commented May 18, 2021

Uh oh!

gziolo commented May 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

youknowriad commented May 18, 2021

Uh oh!

youknowriad commented May 18, 2021

Uh oh!

ellatrix commented May 18, 2021

Uh oh!

gziolo commented May 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gziolo commented May 19, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gziolo commented May 14, 2021 •

edited

Loading

gziolo commented May 17, 2021 •

edited

Loading

gziolo May 17, 2021 •

edited

Loading

gziolo commented May 18, 2021 •

edited

Loading

gziolo commented May 18, 2021 •

edited

Loading