Skip to content

Query: Pass post ID to old_slug_redirect_url filter#12051

Open
deepakpra wants to merge 1 commit into
WordPress:trunkfrom
deepakpra:fix/old-slug-redirect-url-post-id
Open

Query: Pass post ID to old_slug_redirect_url filter#12051
deepakpra wants to merge 1 commit into
WordPress:trunkfrom
deepakpra:fix/old-slug-redirect-url-post-id

Conversation

@deepakpra

@deepakpra deepakpra commented Jun 2, 2026

Copy link
Copy Markdown

Summary

This updates wp_old_slug_redirect() to pass the resolved redirect post ID to the old_slug_redirect_url filter.

Why

Callbacks filtering the old slug redirect URL currently receive only the generated redirect URL. Passing the post ID gives callbacks enough context to inspect the matched post before changing or disabling the redirect.

Use of AI Tools

AI assistance: Yes
Tool(s): ChatGPT, Codex
Model(s): GPT-5.5
Used for: Initial code review, and test suggestions; final implementation and tests were reviewed and edited by me.

Testing

Ran:

npm run test:php -- --filter Tests_Rewrite_OldSlugRedirect

Trac Ticket

https://core.trac.wordpress.org/ticket/39442

@deepakpra deepakpra marked this pull request as draft June 2, 2026 08:35
@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown

Trac Ticket Missing

This pull request is missing a link to a Trac ticket. For a contribution to be considered, there must be a corresponding ticket in Trac.

To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. More information about contributing to WordPress on GitHub can be found in the Core Handbook.

@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props deepakprajapati.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@deepakpra deepakpra marked this pull request as ready for review June 3, 2026 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant