Skip to content

Adjust vertical alignment of favorites button in install tab#11817

Open
shreyasikhar wants to merge 4 commits into
WordPress:trunkfrom
shreyasikhar:ticket/65231
Open

Adjust vertical alignment of favorites button in install tab#11817
shreyasikhar wants to merge 4 commits into
WordPress:trunkfrom
shreyasikhar:ticket/65231

Conversation

@shreyasikhar

@shreyasikhar shreyasikhar commented May 13, 2026

Copy link
Copy Markdown

This pull request makes a small CSS adjustment to the vertical alignment of buttons in the plugin favorites tab. The change ensures that buttons within .plugin-install-tab-favorites are aligned to the top instead of the default baseline.

Before After
image image

Ticket: https://core.trac.wordpress.org/ticket/65231

…in install tab

Co-authored-by: Copilot <copilot@github.com>
@github-actions

github-actions Bot commented May 13, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props shreyasikhar26, joedolson.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@joedolson joedolson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @sabernhardt's comments about moving this to a different stylesheet. buttons.css should be primarily focused on the baseline styles for buttons, and exceptions belong elsewhere. I think that list-tables.css is the most appropriate place.

I also agree that setting vertical alignment may not be the best solution; it makes more sense to modernize to use flex layout.

@shreyasikhar

Copy link
Copy Markdown
Author

Thanks @joedolson for pointing it out, I have addressed the feedback by updating the code. Also, updated the screenshot in the PR description after the change.

@shreyasikhar shreyasikhar requested a review from joedolson June 10, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants