Skip to content

Code Quality: Remove unused $hooked_blocks variable in get_all_registered()#11429

Open
Soean wants to merge 1 commit intoWordPress:trunkfrom
Soean:hooked_blocks_unused
Open

Code Quality: Remove unused $hooked_blocks variable in get_all_registered()#11429
Soean wants to merge 1 commit intoWordPress:trunkfrom
Soean:hooked_blocks_unused

Conversation

@Soean
Copy link
Copy Markdown
Member

@Soean Soean commented Apr 2, 2026 •
edited
Loading

The unused variable $hooked_blocks in WP_Block_Patterns_Registry->get_all_registered() has been removed.

Introduced in: https://core.trac.wordpress.org/changeset/56805/trunk/src/wp-includes/class-wp-block-patterns-registry.php
Unused since: https://core.trac.wordpress.org/changeset/59101/trunk/src/wp-includes/class-wp-block-patterns-registry.php

Trac ticket: https://core.trac.wordpress.org/ticket/64898

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props soean, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

mukeshpanchal27
mukeshpanchal27 approved these changes Apr 2, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@mukeshpanchal27
Copy link
Copy Markdown
Member

mukeshpanchal27 commented Apr 2, 2026

Do you have plan to open ticket for this issue?

@Soean
Copy link
Copy Markdown
Member Author

Soean commented Apr 2, 2026

Maybe we can use the PHPStan ticket: https://core.trac.wordpress.org/ticket/64898

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mukeshpanchal27 mukeshpanchal27 mukeshpanchal27 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Soean @mukeshpanchal27