I18N: Use _x() to disambiguate 'Library' for translators#11404
I18N: Use _x() to disambiguate 'Library' for translators#11404sanketio wants to merge 2 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @1178653+wordpress-develop-pr-bot[bot]@users.noreply.github.com. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Summary
The string
"Library"was used in two unrelated contexts without translator context:In languages like German, these concepts use different words (
Mediathekvs.Bibliothek), making a single translation impossible without disambiguation.Changes
wp-admin/menu.php: Changed__( 'Library' )to_x( 'Library', 'Media Library menu item' )for the Media submenu entry.wp-includes/build/routes/font-list/content.jsandcontent.min.js: Changed__("Library")to_x("Library", "Font library")for the installed-fonts tab title, aligning it with the already-correct_x()usage in the Font Library modal.Testing
No functional change in English. Translators can now provide distinct translations for each context via
_x().Trac ticket: https://core.trac.wordpress.org/ticket/64982
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.