Editor: Enqueue assets for format library for the block editor#1125
Closed
gziolo wants to merge 1 commit intoWordPress:masterfrom
gziolo:update/format-library-enqueue
Closed
Editor: Enqueue assets for format library for the block editor#1125gziolo wants to merge 1 commit intoWordPress:masterfrom gziolo:update/format-library-enqueue
gziolo wants to merge 1 commit intoWordPress:masterfrom
gziolo:update/format-library-enqueue
Conversation
Member
Author
|
@youknowriad and @ellatrix – do you think it's safe to assume that we always need to load format library? We do something similar for:
|
Member
|
You mean for WordPress? I guess so, otherwise it should just have no formats available without errors. |
Member
Author
Yes, for WordPress. It's going to be loaded for all pages that render the block editor moving forward. Related commit: 0df2817. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/52920
Ensures that
wp-format-libraryassets are always loaded for the block editor. Otherwise, they have to be loaded individually for every screen that needs it. It's similar to howwp-block-directoryassets are handled.This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.