Fix wp_dashboard_right_now() to correctly pass post type to the class#11127
Fix wp_dashboard_right_now() to correctly pass post type to the class#11127ocean90 wants to merge 1 commit intoWordPress:trunkfrom
Conversation
|
Can confirm that this works! |
|
Can also confirm that the correct icons are displayed again. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Can confirm that the correct icons are displayed. 👍🏼 |
|
The correct icons are now displayed. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
sabernhardt
left a comment
There was a problem hiding this comment.
LGTM 👍
I wondered why this did not use esc_attr(), but escaping $post_type is unnecessary. The variable can only equal 'post' or 'page'.
Before:
After:
Trac ticket: https://core.trac.wordpress.org/ticket/43084
Created during company contributor day with @KarinChristen @krokodok @velthy @derpaschi.
Use of AI Tools
None.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.